Add kz_2d option #1035
Merged
Add kz_2d option #1035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Using "complex" as the new default (as described in #1026) causes about half of the tests to fail (assuming it's correct to set the default |
oskooi
reviewed
Oct 13, 2019
|
|
||
| if self.special_kz and self.k_point is False: | ||
| self.k_point = Vector3() | ||
|
|
There was a problem hiding this comment.
Lines 641-653 should be replaced with:
self.special_kz = False
if self.cell_size.z == 0 and self.k_point and self.k_point.z != 0:
if kz_2d == "complex":
self.special_kz = True
self.force_complex_fields = True
elif kz_2d == "real/imag":
self.special_kz = True
self.force_complex_fields = False
elif kz_2d == "3d":
self.special_kz = False
else:
raise ValueError("Invalid kz_2d option: {} not in [complex, real/imag, 3d]".format(kz_2d))
Setting kpoint=0 when special_kz=True is incorrect since its non-zero z component is what is used in the calculations.
oskooi
reviewed
Oct 13, 2019
python/tests/special_kz.py
Outdated
| t_real_imag = time() - start | ||
|
|
||
| start = time() | ||
| Rmeep_3d = self.refl_planar(theta, '3d') |
There was a problem hiding this comment.
The 3d simulation can probably be removed (in order to save time) since this particular test is only for the special_kz=True feature.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* Add kz_2d option * Set default k_point when special_kz is True * Only use kz_2d when k_point is set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026.