arbitrary frequency grid for DFT functions in Python interface #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Please keep your documentation work on a separate branch and separate PR, to make PRs easier to review.) |
stevengj
reviewed
Mar 29, 2020
stevengj
reviewed
Mar 29, 2020
stevengj
reviewed
Mar 29, 2020
stevengj
reviewed
Mar 29, 2020
stevengj
reviewed
Mar 29, 2020
stevengj
reviewed
Mar 29, 2020
oskooi
force-pushed
the
unequal_DFT_freqs_python
branch
from
b2e2e78 to
05da95f
Compare
stevengj
reviewed
Mar 30, 2020
stevengj
reviewed
Mar 31, 2020
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…omp#1163) * arbitrary frequency grid for DFT functions in Python interface * fixes * change add_dft_field arguments from freq_min,freq_max to fcen,df * parse add_dft arguments using fix_dft_args and add runtime warning for add_dft_fields * fix TypeError message in fix_dft_args
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1070.
Follows the outline proposed by @ChristopherHogan in #1070:comment and described in more detail by @stevengj in #1070:comment. All DFT functions can accept either
fcen,df,nfreq(as 3 numbers) or a Numpy arrayfreq.Also includes a test (
python/tests/bend_flux.py) as well as documentation.ToDo: extend this functionality to the Scheme interface?