Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apparent Typo #1170

Merged
merged 2 commits into from
Apr 5, 2020
Merged

Apparent Typo #1170

merged 2 commits into from
Apr 5, 2020

Conversation

aarogon
Copy link
Contributor

@aarogon aarogon commented Apr 3, 2020

I assume that the sentence refers to ω as frequency, not μ.

@oskooi
Copy link
Collaborator

oskooi commented Apr 3, 2020

Good catch, but rather than ω you should use "$\omega$".

@aarogon
Copy link
Contributor Author

aarogon commented Apr 3, 2020

I was trying to be consistent with the other unicode Greek characters there. Would it be better to have them all changed to LaTeX-style names?

@oskooi
Copy link
Collaborator

oskooi commented Apr 3, 2020

Latex is preferred although unfortunately the documentation is not as consistent as it should be. For example, there are occurrences of ε and μ when these should be $\varepsilon$ and $\mu$. If you can go through and make all these changes as part of this PR, that would be helpful.

When editing the markdown files of the documentation, make sure you verify that it renders correctly by viewing the page locally in your browser using mkdocs. From a shell terminal, you simply run mkdocs serve from the source tree and then paste the URL that is shown into your browser.

@stevengj stevengj merged commit 001d6e5 into NanoComp:master Apr 5, 2020
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants