Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For Bug#1117 #1219

Merged
merged 76 commits into from
May 19, 2020
Merged

For Bug#1117 #1219

Show file tree
Hide file tree
Changes from 71 commits
Commits
Show all changes
76 commits
Select commit Hold shift + click to select a range
051e579
Implement gyrotropic susceptibility class.
seewhydee May 8, 2019
c068942
Add Python and Scheme support for gyrotropic media.
seewhydee May 8, 2019
3743358
Initialize bias vector in python susceptibility struct.
May 9, 2019
88ea6ca
Remove "bias" from gyrotropic_susceptibility; the information is alre…
May 10, 2019
3115557
Add gyrotropic media to docs
May 22, 2019
c0b5939
Minor copyedit
May 22, 2019
9e595d0
Fix logic in py_susceptibility_to_susceptibility
seewhydee May 22, 2019
074ecf0
In add_susceptibilities, always pass a 3-vector as gyrotropic bias
seewhydee May 22, 2019
579b76d
First try at gyrotropic media tutorial
May 23, 2019
79c120b
Merge branch 'master' of https://github.com/seewhydee/meep
May 23, 2019
afd8583
Fix errors in gyrotropy formulas in notes
May 23, 2019
80c6096
Merge branch 'master' of https://github.com/seewhydee/meep
seewhydee May 23, 2019
69a302b
Re-implemention of gyrotropy using LLG equation
seewhydee May 23, 2019
2481e16
Tweak handling of sigma tensor in gyrotropic case
seewhydee May 23, 2019
d6cc485
Update Python doc.
May 24, 2019
9267c35
Drop 2pi factor from gyrotropic sigma
May 24, 2019
77812cd
Doc updates
May 24, 2019
14454cf
Fix last change to update_P
May 24, 2019
5e0f371
Fix printf typo
May 24, 2019
722c9c6
Remove spurious 2pi factor in alpha (which is not a rate)
May 24, 2019
e091b5e
Minor code tweak
May 24, 2019
104fff9
Use a central-difference scheme for the LLG dynamics, which seems sli…
seewhydee May 25, 2019
054c5f5
Try implementing the full nonlinear LLG equation
seewhydee May 26, 2019
1563674
Add implicit static polarization to gyrotropy implementation
seewhydee May 27, 2019
a7b1e27
Put static P back in in subtract_P
seewhydee May 27, 2019
1dc5912
Add gyrotropy example
seewhydee May 27, 2019
8dd1988
Fix; use LOOP_OVER_VOL instead of LOOP_OVER_VOL_OWNED to ensure updat…
May 28, 2019
0842ad6
Clamp the magnitude of the LLG polarization vector.
May 28, 2019
9364b6f
Revert inadvertent unrelated change to meep.i
May 28, 2019
18831d2
Minor code cleanup
May 28, 2019
006365d
Flag "needs_W_notowned" for gyrotropic media
May 29, 2019
021cf48
Update gyrotropic P components explicitly; don't use LOOP_OVER_VOL_OWNED
May 30, 2019
164b5a8
Enable needs_P on all components for gyrotropic media
seewhydee May 30, 2019
6515785
Fix gyrotropy scheme to track 9 polarization components per unit cell.
seewhydee May 30, 2019
be5ae68
Revert unrelated last change to meep.i
seewhydee May 30, 2019
795fef5
Avoiding need for allocation of P_tmp in gyrotropy_data.
May 31, 2019
83f42e1
Implement num_cinternal_notowned stuff for gyrotropic media
May 31, 2019
7fa88a2
Update documentation for gyrotropic media, and relax some minor restr…
May 31, 2019
3028e30
Add virtual keywords to gyrotropic_susceptibility methods
May 31, 2019
ecd71c2
Merge latest changes from master
seewhydee Jun 2, 2019
1cc846e
Merge latest changes from master
seewhydee Jun 2, 2019
2951bef
Remove gyrotropic-dispersion.py (incomplete attempt)
seewhydee Jun 2, 2019
d29cbe8
Complete merge
seewhydee Jun 2, 2019
2c6df33
Update Materials.md to discuss both Lorentzian and LLG gyrotropic models
seewhydee Jun 2, 2019
67e60de
Introduce a new gyrotropy_model enum type, to allow for the LLG model.
seewhydee Jun 2, 2019
566e32c
More plumbing to provide support for Landau-Lifshitz-Gilbert type gyr…
Jun 3, 2019
6b76ccc
Fix typo in susceptibility update equation
Jun 4, 2019
aa32c6d
Fix typos in Faraday rotation formula in docs
Jun 4, 2019
5211c87
Merge from master
Jun 4, 2019
3934533
Merge from master
Jun 4, 2019
c499a46
Reimplement linearized-LLG updating equations
Jun 4, 2019
545da4a
Fix typo
Jun 4, 2019
c6576ec
Minor code clarification
Jun 4, 2019
aedb897
Fix Faraday rotation example
seewhydee Jun 5, 2019
9d91c16
Merge from master
seewhydee Jun 5, 2019
a39cea1
For Landau-Lifshitz-Gilbert model, ignore the magnitude of the bias v…
seewhydee Jun 5, 2019
01d9f98
Fix minor hiccup in docs.
seewhydee Jun 5, 2019
d2ab174
Support dumping and undumping of gyrotropic susceptibilities
Jun 6, 2019
329ab89
Doc updates and minor tweaks accompanying last merge
Jun 6, 2019
256aa89
Translate Faraday rotation tutorial from Python to Scheme
Jun 12, 2019
9b7c6b7
Fix typo in last change
Jun 12, 2019
0bc91b2
Fix missing 2pi factor in gyrotropic LLG susceptibility's sigma param…
Jun 12, 2019
2ee3076
Minor fixes for gyrotropy documentation
Jun 12, 2019
356a507
Add Faraday rotation unit test
Jun 13, 2019
5742b89
Use absolute tolerance (in degrees) for Faraday rotation unit test
seewhydee Jun 13, 2019
f649858
Add faraday rotation test to python/Makefile.am
seewhydee Jun 13, 2019
653c59e
Merge remote-tracking branch 'upstream/master'
seewhydee Apr 14, 2020
ed3f3dd
Merge remote-tracking branch 'upstream/master'
seewhydee Apr 22, 2020
6f0928f
Relax rules on needs_P for gyrotropic media (Bug#1117)
seewhydee Apr 22, 2020
985b560
Remove gyrotropic_susceptibility::needs_P, falling back on parent ver…
seewhydee May 14, 2020
d77df52
Merge remote-tracking branch 'upstream/master'
seewhydee May 14, 2020
6310d75
Set gyrotropic_susceptibility::num_cinternal_notowned_needed as sugge…
seewhydee May 16, 2020
e4f43e6
Merge remote-tracking branch 'upstream/master'
seewhydee May 16, 2020
506150e
Revert accidental code changes.
seewhydee May 18, 2020
dd6d8a5
Whitespace fixes.
seewhydee May 18, 2020
367c149
Whitespace changes.
seewhydee May 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/meep.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,7 +303,6 @@ class gyrotropic_susceptibility : public susceptibility {
const grid_volume &gv, void *data) const;
virtual void *copy_internal_data(void *data) const;

virtual bool needs_P(component c, int cmp, realnum *W[NUM_FIELD_COMPONENTS][2]) const;
virtual void update_P(realnum *W[NUM_FIELD_COMPONENTS][2],
realnum *W_prev[NUM_FIELD_COMPONENTS][2], double dt, const grid_volume &gv,
void *P_internal_data) const;
Expand Down
1 change: 1 addition & 0 deletions src/meepgeom.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,6 +1190,7 @@ static bool susceptibility_equiv(const susceptibility *o0, const susceptibility
if (!vector3_equal(o0->bias, o->bias)) return 0;
if (o0->frequency != o->frequency) return 0;
if (o0->gamma != o->gamma) return 0;
if (o0->alpha != o->alpha) return 0;
if (o0->noise_amp != o->noise_amp) return 0;
if (o0->drude != o->drude) return 0;
if (o0->saturated_gyrotropy != o->saturated_gyrotropy) return 0;
Expand Down
15 changes: 4 additions & 11 deletions src/susceptibility.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,13 +431,6 @@ void *gyrotropic_susceptibility::copy_internal_data(void *data) const {
return (void *)dnew;
}

bool gyrotropic_susceptibility::needs_P(component c, int cmp,
realnum *W[NUM_FIELD_COMPONENTS][2]) const {
if (!is_electric(c) && !is_magnetic(c)) return false;
direction d0 = component_direction(c);
return (d0 == X || d0 == Y || d0 == Z) && sigma[c][d0] && W[c][cmp];
}

stevengj marked this conversation as resolved.
Show resolved Hide resolved
// Similar to the OFFDIAG macro, but without averaging sigma.
#define OFFDIAGW(g, sx, s) (0.25 * (g[i] + g[i - sx] + g[i + s] + g[i + s - sx]))

Expand Down Expand Up @@ -471,8 +464,8 @@ void gyrotropic_susceptibility::update_P(realnum *W[NUM_FIELD_COMPONENTS][2],
invdet * (gd * gd + gz * gz)}};

FOR_COMPONENTS(c) DOCMP2 {
if (d->P[c][cmp][0]) {
const direction d0 = component_direction(c);
stevengj marked this conversation as resolved.
Show resolved Hide resolved
const direction d0 = component_direction(c);
if (d->P[c][cmp][0] && sigma[c][d0]) {
const realnum *w0 = W[c][cmp], *s = sigma[c][d0];

if (!w0 || !s || (d0 != X && d0 != Y && d0 != Z))
Expand Down Expand Up @@ -532,8 +525,8 @@ void gyrotropic_susceptibility::update_P(realnum *W[NUM_FIELD_COMPONENTS][2],
invdet * (gd * gd + gz * gz)}};

FOR_COMPONENTS(c) DOCMP2 {
if (d->P[c][cmp][0]) {
const direction d0 = component_direction(c);
const direction d0 = component_direction(c);
if (d->P[c][cmp][0] && sigma[c][d0]) {
const realnum *w0 = W[c][cmp], *s = sigma[c][d0];

if (!w0 || !s || (d0 != X && d0 != Y && d0 != Z))
Expand Down