Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip adding integration edge weights in array slices #1463

Merged
merged 3 commits into from
Jan 4, 2021
Merged

skip adding integration edge weights in array slices #1463

merged 3 commits into from
Jan 4, 2021

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented Jan 4, 2021

Addresses #1456 (comment).

@oskooi oskooi changed the title skip adding interpolation weights in array slices skip adding integration weights in array slices Jan 4, 2021
@stevengj stevengj changed the title skip adding integration weights in array slices skip adding integration edge weights in array slices Jan 4, 2021
stevengj
stevengj reviewed Jan 4, 2021
View reviewed changes
src/array_slice.cpp Outdated Show resolved Hide resolved
@oskooi
Copy link
Collaborator Author

oskooi commented Jan 4, 2021

Tests are passing and this is ready to be merged.

@stevengj stevengj merged commit bd887e7 into NanoComp:master Jan 4, 2021
@oskooi oskooi deleted the slice_interp_empty branch January 4, 2021 20:13
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@oskooi
skip adding integration edge weights in array slices (NanoComp#1463)
ee963fc 
* skip adding interpolation weights in array slices

* remove data->snap ? from get_array_slice_chunkloop

* update hard-coded array slice values in python/tests/cavity_arrayslice.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengj stevengj stevengj left review comments

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oskooi @stevengj