meep change protos with harminv complex #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meep change protos with harminv complex This patch concern the meep package, it needs a prereq of similar patch for harminv package. This is related to meep issue 13 #13 The initial reported problem was at make check: === [ 259s] FAIL: aniso_disp [ 273s] FAIL: convergence_cyl_waveguide [ 396s] FAIL: 2D_convergence === ../meep-1.2.1/tests> grep failure test-suite.log test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude === Signed-off-by: Michel Normand <normand@linux.vnet.ibm.com>
|
Prerequisite for this is NanoComp/harminv#1, after which I'll make a new Harminv release and the Meep |
|
Thanks, I will merge this and then fix it up to remain backward compatible with the old harminv (by checking the |
stevengj
added a commit
that referenced
this pull request
Mar 31, 2015
meep change protos with harminv complex
stevengj
added a commit
that referenced
this pull request
Mar 31, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
meep change protos with harminv complex
This patch concern the meep package,
it needs a prereq of similar patch for harminv package.
This is related to meep issue 13
#13
The initial reported problem was at make check:
[ 259s] FAIL: aniso_disp
[ 273s] FAIL: convergence_cyl_waveguide
[ 396s] FAIL: 2D_convergence
../meep-1.2.1/tests> grep failure test-suite.log
test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude
test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude
test-suite.log:harminv: failure on line 853 of harminv.c: argument out of range in harminv_get_amplitude
Signed-off-by: Michel Normand normand@linux.vnet.ibm.com