Fix memory leaks in src_vol
#1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahoenselaar
force-pushed
the
srcvol
branch
2 times, most recently
from
13357a4 to
db519de
Compare
ahoenselaar
added a commit
to ahoenselaar/meep
that referenced
this pull request
Jun 28, 2021
Along with NanoComp#1644, this shuld get us into a position where the AddressSanitizer workflow succeeds.
stevengj
pushed a commit
that referenced
this pull request
Jun 30, 2021
Along with #1644, this shuld get us into a position where the AddressSanitizer workflow succeeds.
stevengj
reviewed
Jun 30, 2021
stevengj
reviewed
Jun 30, 2021
The old implementation's weak point was the `add_to` method, which sometimes transferred memory ownership correctly and sometimes did not. * Rewrite `src_vol` using STL containers. * Replace the linked list of source volumes in `fields_chunk` with a vector. Adjust code that iterates for source volumes accordingly. * Exclude `fields_chunk` from SWIG wrappers.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
Along with NanoComp#1644, this shuld get us into a position where the AddressSanitizer workflow succeeds.
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
The old implementation's weak point was the `add_to` method, which sometimes transferred memory ownership correctly and sometimes did not. * Rewrite `src_vol` using STL containers. * Replace the linked list of source volumes in `fields_chunk` with a vector. Adjust code that iterates for source volumes accordingly. * Exclude `fields_chunk` from SWIG wrappers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old implementation's weak point was the
add_tomethod, whichsometimes transferred memory ownership correctly and sometimes did not.
src_volusing STL containers.fields_chunkwith avector. Adjust code that iterates over source volumes accordingly.
fields_chunkfrom SWIG wrappers.