fix step_* to allow tiled (is,ie) #1703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* fix step_* to allow tiled (is,ie) * it really seems like this should be the 'is' corner
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* fix step_* to allow tiled (is,ie) * it really seems like this should be the 'is' corner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix problem in #1653 identified in #1655, where
step_curldid not allow(little_corner0, big_corner)to be broken into smaller tiles.The basic issue is that offsets into the PML "sigma" arrays need to be computed relative to the "global"
ilocof the loop counters relative to the whole chunkgv, not relative to the tile(is,ie), but this was not being done correctly.