Lower tolerance of CW and eigenfrequency solver tests for single precision #1714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevengj
reviewed
Jul 29, 2021
| @@ -137,7 +137,7 @@ int check_2d_3d(ndim dim, const double xmax, double a, component c0, component c | |||
| continuous_src_time src(w); | |||
| f.add_point_source(c0, src, zero_vec(dim)); | |||
| if (c1 != NO_COMPONENT) f.add_point_source(c1, src, zero_vec(dim), 0.7654321); | |||
| f.solve_cw(1e-6); | |||
| f.solve_cw(sizeof(realnum) == sizeof(float) ? 1e-5 : 1e-6); | |||
There was a problem hiding this comment.
Probably not necessary to change this, but it's fine as long as the test still passes.
Codecov Report
@@ Coverage Diff @@
## master #1714 +/- ##
=======================================
Coverage 73.33% 73.34%
=======================================
Files 13 13
Lines 4527 4528 +1
=======================================
+ Hits 3320 3321 +1
Misses 1207 1207
|
|
Does any of the documentation need to change? |
stevengj
added a commit
that referenced
this pull request
Jul 30, 2021
* fix factor 2 * fix * fix * fix * kpoint * fix * Fix the `binary_partition` copy constructor. (#1702) * Fix the `binary_partition` copy constructor. Prevents issues with older compilers. \#1683 #1701 * Update src/structure_dump.cpp Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * single precision test tol * single precision test tol * Fix factor of 2 in adjoint gradients when not using complex fields (#1704) * fix factor 2 * fix * fix * fix * single precision test tol * single precision test tol * Update python/adjoint/objective.py Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * assertVectorsClose works for scalars as well as vectors (#1712) * assertVectorsClose works for scalars as well as vectors * rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such * add --with-coverage to control usage of Python coverage tests (#1713) * add --with-coverage to control usage of Python coverage tests * move --with-coverage to correct CI line * flush subnormals on x86 (#1709) * flush subnormals on x86 * less aggressive error threshold in single precision * increase single-precision tolerance * update tols in test_array_metadata * update for assertVectorsClose rename * lower tolerance in single precision * Lower tolerance of CW and eigenfrequency solver tests for single precision (#1714) * lower tolerance of CW and eigenfrequency solver tests for single precision * remove change in default argument from Python wrappers * fix factor 2 * fix * kpoint * fix * single precision test tol * single precision test tol * using real * using real * fix rebase * fix * fix Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Andreas Hoenselaar <ahoens@google.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Ardavan Oskooi <ardavano@google.com>
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…ision (NanoComp#1714) * lower tolerance of CW and eigenfrequency solver tests for single precision * remove change in default argument from Python wrappers
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
* fix factor 2 * fix * fix * fix * kpoint * fix * Fix the `binary_partition` copy constructor. (NanoComp#1702) * Fix the `binary_partition` copy constructor. Prevents issues with older compilers. \NanoComp#1683 NanoComp#1701 * Update src/structure_dump.cpp Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * single precision test tol * single precision test tol * Fix factor of 2 in adjoint gradients when not using complex fields (NanoComp#1704) * fix factor 2 * fix * fix * fix * single precision test tol * single precision test tol * Update python/adjoint/objective.py Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * assertVectorsClose works for scalars as well as vectors (NanoComp#1712) * assertVectorsClose works for scalars as well as vectors * rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such * add --with-coverage to control usage of Python coverage tests (NanoComp#1713) * add --with-coverage to control usage of Python coverage tests * move --with-coverage to correct CI line * flush subnormals on x86 (NanoComp#1709) * flush subnormals on x86 * less aggressive error threshold in single precision * increase single-precision tolerance * update tols in test_array_metadata * update for assertVectorsClose rename * lower tolerance in single precision * Lower tolerance of CW and eigenfrequency solver tests for single precision (NanoComp#1714) * lower tolerance of CW and eigenfrequency solver tests for single precision * remove change in default argument from Python wrappers * fix factor 2 * fix * kpoint * fix * single precision test tol * single precision test tol * using real * using real * fix rebase * fix * fix Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Andreas Hoenselaar <ahoens@google.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Ardavan Oskooi <ardavano@google.com>
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
…ision (NanoComp#1714) * lower tolerance of CW and eigenfrequency solver tests for single precision * remove change in default argument from Python wrappers
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
* fix factor 2 * fix * fix * fix * kpoint * fix * Fix the `binary_partition` copy constructor. (NanoComp#1702) * Fix the `binary_partition` copy constructor. Prevents issues with older compilers. \NanoComp#1683 NanoComp#1701 * Update src/structure_dump.cpp Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * single precision test tol * single precision test tol * Fix factor of 2 in adjoint gradients when not using complex fields (NanoComp#1704) * fix factor 2 * fix * fix * fix * single precision test tol * single precision test tol * Update python/adjoint/objective.py Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> * assertVectorsClose works for scalars as well as vectors (NanoComp#1712) * assertVectorsClose works for scalars as well as vectors * rename ApproxComparisonMixin -> ApproxComparisonTestCase, since it is a subclass of TestCase, and use it as such * add --with-coverage to control usage of Python coverage tests (NanoComp#1713) * add --with-coverage to control usage of Python coverage tests * move --with-coverage to correct CI line * flush subnormals on x86 (NanoComp#1709) * flush subnormals on x86 * less aggressive error threshold in single precision * increase single-precision tolerance * update tols in test_array_metadata * update for assertVectorsClose rename * lower tolerance in single precision * Lower tolerance of CW and eigenfrequency solver tests for single precision (NanoComp#1714) * lower tolerance of CW and eigenfrequency solver tests for single precision * remove change in default argument from Python wrappers * fix factor 2 * fix * kpoint * fix * single precision test tol * single precision test tol * using real * using real * fix rebase * fix * fix Co-authored-by: Mo Chen <mochen@Mos-MacBook-Pro.local> Co-authored-by: Andreas Hoenselaar <ahoens@google.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: Ardavan Oskooi <ardavano@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses a comment by @stevengj in #1698.