Add support for fully local HDF5 files and shared dumping of meep::structure #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1715 +/- ##
==========================================
+ Coverage 73.34% 73.42% +0.07%
==========================================
Files 13 13
Lines 4528 4545 +17
==========================================
+ Hits 3321 3337 +16
- Misses 1207 1208 +1
|
stevengj
approved these changes
Jul 29, 2021
oskooi
reviewed
Aug 2, 2021
oskooi
reviewed
Aug 2, 2021
|
LGTM. |
oskooi
approved these changes
Aug 12, 2021
ahoenselaar
approved these changes
Aug 16, 2021
bencbartlett
pushed a commit
to bencbartlett/meep
that referenced
this pull request
Sep 9, 2021
…ructure (NanoComp#1715) * Add support for fully local HDF5 files and shared dumping of meep::structure * Add support for fully local HDF5 files and shared dumping of meep::structure * Update python func docs * Update python API documentation
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
…ructure (NanoComp#1715) * Add support for fully local HDF5 files and shared dumping of meep::structure * Add support for fully local HDF5 files and shared dumping of meep::structure * Update python func docs * Update python API documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for dumping meep:structure to sharded files where each process writes out the data for the chunks it owns to its own file (typically named after the process rank). This is useful when running with MPI but there is no proper parallel file support on the running system.
To support this, add a 'local' mode to the h5file wrapper to support writing to local files (with parallel or MPI I/O)