Issue# 1762 - Add an option to build SWIG python bindings with threads enabled #1763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…N_THREAD_{BEGIN,END}_BLOCK
kkg4theweb
changed the title
stevengj
reviewed
Sep 29, 2021
oskooi
approved these changes
Sep 30, 2021
ahoenselaar
approved these changes
Sep 30, 2021
stevengj
reviewed
Sep 30, 2021
mawc2019
pushed a commit
to mawc2019/meep
that referenced
this pull request
Nov 3, 2021
…s enabled (NanoComp#1763) * Enable configure builds with SWIG threading and/or debugging enabled * Surround python codeblock that need to be thread-safe with SWIG_PYTHON_THREAD_{BEGIN,END}_BLOCK * define and use SWIG_PYTHON_THREAD_SCOPED_BLOCK to make py calls GIL-safe * enable swig threads for the PYv3.9/MPI CI test * Add docs describing the new feature. * Add more comments describing the new SWIG_PYTHON_THREAD_SCOPED_BLOCK macro. * switch the MEEP_SWIG_PYTHON_DEBUG to use master_printf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a configure option to enable SWIG python bindings with threads enabled.