validation check in loop_in_chunks #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mochen4
commented
Apr 13, 2022
mochen4
commented
Apr 13, 2022
mochen4
commented
Apr 13, 2022
| @@ -406,7 +417,7 @@ void fields::loop_in_chunks(field_chunkloop chunkloop, void *chunkloop_data, con | |||
| grid_volume gvu(chunks[i]->gv); | |||
| ivec _iscoS(S.transform(gvu.little_owned_corner(cS), sn)); | |||
| ivec _iecoS(S.transform(gvu.big_owned_corner(cS), sn)); | |||
| ivec iscoS(max(user_volume.little_owned_corner(cgrid), min(_iscoS, _iecoS))), iecoS(max(_iscoS, _iecoS)); // fix ordering due to to transform | |||
| ivec iscoS(max(user_volume.little_owned_corner(cgrid), min(_iscoS, _iecoS))), iecoS(min(user_volume.big_owned_corner(cgrid), max(_iscoS, _iecoS))); // fix ordering due to to transform | |||
There was a problem hiding this comment.
A potential bug of #1895 is exposed and fixed by this PR. Previously, the grid_volume gvu was thought to be always inside the big_owned_corner of the user_volume so min wasn't taken.
There was a problem hiding this comment.
Would be nice to know the source of this being violated…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2028. Added validation check to loop_in_chunks.