fix bug in plot_boundaries of plot2D for cylindrical coordinates
#2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2136 +/- ##
==========================================
- Coverage 73.18% 73.07% -0.12%
==========================================
Files 17 17
Lines 4942 4951 +9
==========================================
+ Hits 3617 3618 +1
- Misses 1325 1333 +8
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2079 fixed a bug in
plot_boundariesof the visualization routineSimulation.plot2Dfor 3D coordinates . However, in doing so it unfortunately introduced a bug in cylindrical coordinates. This PR fixes that bug.The bug can be demonstrated by
python/examples/zone_plate.py.master
this PR
