-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animate2D for OptimizationProblem #2186
Conversation
Below is a modified version of the Filtering and Thresholding Design Parameters and Broadband Objective Functions tutorial that I'm using to test this.
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2186 +/- ##
==========================================
- Coverage 73.09% 72.93% -0.17%
==========================================
Files 17 17
Lines 4906 4925 +19
==========================================
+ Hits 3586 3592 +6
- Misses 1320 1333 +13
|
Is this ready for review? If so, change the status from "draft". |
65a33d1
to
4d31ceb
Compare
I wanted to get it a little better integrated into OptimizationProblem before marking it for review. With the |
These tests aren't failing on my end.. |
I have same errors in my PR #2188. My guess that this is introduced by some library update, and valgrind shows me that error comes from mpb.cpp |
Looks like the CI is failing for the master branch as well.. They started 3 days ago, which coincides with the latest commit in MPB, any chance that's related? I can't get the master branch of MPB to pass its own tests, but the v1.11.1 tag works fine. |
I was using HEAD of the repo to link with meep, I was also getting errors in make check but it looks like this errors come from guile and not from library itself. Ok, I will run tests on another mpb commit then and see what happens. Update: @thomasdorch you are right, I checked with another mpb version and everything works fine, except test_mpb.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Would you post an example just to see what the output actually looks like?
Very cool! Wish we did this earlier... |
LGTM. Can you add documentation, e.g. at demonstrate this in a tutorial? |
I am working on getting the animation working in Jupyter notebooks so once that works I can just replace some of the current |
The purpose of this PR is to allow plotting of topology optimizations (#2185).
So far, I've modified the Animate2D class to support changing epsilon values in addition to field values.