add/update type hints for JAX wrapper of adjoint solver #2190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2190 +/- ##
==========================================
+ Coverage 73.09% 73.25% +0.15%
==========================================
Files 17 17
Lines 4906 4894 -12
==========================================
- Hits 3586 3585 -1
+ Misses 1320 1309 -11
|
|
Since @ianwilliamson is okay with this PR, LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new and also updates existing type hints for all functions which make up the JAX wrapper of the adjoint solver. Several of these changes are necessary because #1855 modified the API for
meep._get_gradientsreplacing the forward and adjoint field arguments of typenumpy.ndarraywithmeep.DftFields.The function
gather_design_region_fieldsis removed because it is no longer used.cc @ianwilliamson