Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjoint typehints #2202

Merged
merged 9 commits into from
Sep 22, 2022
Merged

Adjoint typehints #2202

merged 9 commits into from
Sep 22, 2022

Conversation

smartalecH
Copy link
Collaborator

@smartalecH smartalecH commented Aug 18, 2022 •
edited
Loading

This PR focuses on type hints for the adjoint model. Future PRs should focus on the

  • Docstrings
  • Adjoint overview page in docs

@smartalecH smartalecH marked this pull request as draft August 18, 2022 18:38
@codecov-commenter
Copy link

codecov-commenter commented Aug 18, 2022 •
edited
Loading

Codecov Report

Merging #2202 (bd59312) into master (0a5aaee) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2202      +/-   ##
==========================================
+ Coverage   73.20%   73.21%   +0.01%     
==========================================
  Files          17       17              
  Lines        4904     4906       +2     
==========================================
+ Hits         3590     3592       +2     
  Misses       1314     1314
Impacted Files Coverage Δ
python/adjoint/objective.py 93.03% <100.00%> (+0.03%) ⬆️
python/adjoint/optimization_problem.py 57.29% <100.00%> (+0.22%) ⬆️

@smartalecH smartalecH marked this pull request as ready for review September 22, 2022 16:12
oskooi
oskooi reviewed Sep 22, 2022
View reviewed changes
python/adjoint/utils.py Outdated Show resolved Hide resolved
oskooi
oskooi reviewed Sep 22, 2022
View reviewed changes
python/adjoint/objective.py Outdated Show resolved Hide resolved
@smartalecH smartalecH changed the title Adjoint docs Adjoint typehints Sep 22, 2022
@stevengj stevengj merged commit 7f0469f into NanoComp:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianwilliamson ianwilliamson ianwilliamson left review comments

@oskooi oskooi oskooi approved these changes

Assignees
No one assigned
Labels
adjoint optimization documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@smartalecH @codecov-commenter @oskooi @ianwilliamson @stevengj