Replace blocks with prism in mode-decomposition.py #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a meep user, thank you! Would it be possible to get the prism type added to the Python user interface as well (either in this or perhaps a separate PR)? |
|
The prism type for Python was merged in #345. |
|
Ah, I was referring to the documentation for the Python user interface (specifically Python_User_Interface.md). Now that the prism type is added it would be great for users to know the correct function inputs. Thanks for all these great additions to meep! |
|
Oh, I see. Yes, we'll get documentation up very soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a request from Ardavan.
@stevengj @oskooi