Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dft_energy Python support #747

Merged
merged 4 commits into from
Mar 8, 2019
Merged

Add dft_energy Python support #747

merged 4 commits into from
Mar 8, 2019

Conversation

ChristopherHogan
Copy link
Contributor

@ChristopherHogan ChristopherHogan commented Feb 27, 2019 •
edited
Loading

TODO

  1. Tests
  2. I don't know what DftEnergy.num_components should be. It's the value that we multiply the number of dft pixels by in the fragment_stats. For dft_near2far it's 4, for dft_force it's 6, for dft_flux it's 4, etc.
    @stevengj @oskooi

@oskooi oskooi mentioned this pull request Mar 4, 2019
Merged
@stevengj
Copy link
Collaborator

stevengj commented Mar 6, 2019

DftEnergy.num_components should be 12 (in 3d): E, D, H, and B fields, 3 components each.

@ChristopherHogan ChristopherHogan changed the title WIP: Add dft_energy Python support Add dft_energy Python support Mar 6, 2019
@ChristopherHogan
Copy link
Contributor Author

Added test and fixed remaining TODO items.

@oskooi oskooi mentioned this pull request Mar 7, 2019
Merged
@stevengj stevengj merged commit 2cba210 into NanoComp:master Mar 8, 2019
@ChristopherHogan ChristopherHogan deleted the chogan/dft_energy branch March 8, 2019 16:23
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
@ChristopherHogan @stevengj
Add dft_energy Python support (NanoComp#747)
ea84c0e 
* Add dft_energy Python support

* Add new functions to meep package

* Add explanation of DftObj class

* Add test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ChristopherHogan @stevengj