-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable Eigenmode Features with Dispersive Materials #919
Merged
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit
Hold shift + click to select a range
4582204
first stab
smartalecH c08123e
Merge branch 'dispersion' of https://github.com/smartalecH/meep into …
smartalecH 8ede31f
begin with test files
smartalecH b546a9c
bug fixes
smartalecH 43b6adb
update test
smartalecH e0ef6ed
merge
smartalecH 23cd5f6
found one bug
smartalecH a4ac0f2
bug fixes, h5 output, and array-slice output
smartalecH b0f65c3
fix serial bugs
smartalecH 78d9053
more serial fixes
smartalecH 939a99e
fix mu issue
smartalecH 6155d59
disable h5 support
smartalecH 6eac066
big fix
smartalecH c4bc10b
generalize matrix inverse and fix parallel bug
smartalecH 97a7b0a
fix memory issue
smartalecH 8a1e635
add tutorial
smartalecH 1f8d91b
Merge branch 'master' of https://github.com/NanoComp/meep into disper…
smartalecH 81f3cc8
minor fixes
smartalecH 041ea9c
refactor
smartalecH a3e4987
check1
smartalecH 8eebb18
case2
smartalecH 9a33f4c
add docs
smartalecH 2d6aa85
cleanup
smartalecH 6046280
check3
smartalecH 176834a
fix test
smartalecH 6ad454a
1 more fix!
smartalecH e28c961
updates
smartalecH 8590db1
det fix
smartalecH File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doesn't
det == 0.0
work?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was just being safe -- do you want it changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
det == 0.0
seems clearer and is safe.(You can't do
det == 0
, on the other hand, because C++ doesn't let you mixcomplex<double>
with scalars of other types.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just fixed with 8590db1