-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
litevVNA support #754
Open
redrathnure
wants to merge
23
commits into
NanoVNA-Saver:main
Choose a base branch
from
redrathnure:feat/litevna-support-screenshots
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
litevVNA support #754
redrathnure
wants to merge
23
commits into
NanoVNA-Saver:main
from
redrathnure:feat/litevna-support-screenshots
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on NanoVNA-Saver#534 (comment) data
readVersion() -> read_fw_version()
read_features() -> init_features()
getFeatures() to get_features()
redrathnure
force-pushed
the
feat/litevna-support-screenshots
branch
from
January 17, 2025 07:09
13b4090
to
714fb90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial version for LiteVNA support. Based on #534 discussion.
Followimg features were tested:
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
LiteVNA64 is detected as SAA2 device. This works somehow however it isn't possible to unitize all hardware functionality (e.g. enable more than 1023 points)
Issue Number: 534
What is the new behavior?
Does this introduce a breaking change?
Other information
na