Merge branch 'main' into fix-microsoft#2845

.github/workflows/dotnet-build.yml

@@ -67,6 +67,31 @@ jobs:
         dotnet build --no-restore --configuration Release -bl /p:SignAssembly=true
     - name: Unit Test
       run: dotnet test --no-build -bl --configuration Release
+  aot-test: # this make sure the AutoGen.Core is aot compatible
+    strategy:
+      fail-fast: false  # ensures the entire test matrix is run, even if one permutation fails
+      matrix:
+        os: [ ubuntu-latest ]
+        version: [ net8.0 ]
+    needs: build
+    defaults:
+      run:
+        working-directory: dotnet
+
+    runs-on: ${{ matrix.os }}
+    steps:
+    - uses: actions/checkout@v4
+      with:
+        fetch-depth: 0 # fetching all
+
+    - name: Setup dotnet
+      uses: actions/setup-dotnet@v4
+      with:
+        global-json-file: dotnet/global.json
+
+    - name: publish AOT testApp, assert static analysis warning count, and run the app
+      shell: pwsh
+      run: ./.tools/test-aot-compatibility.ps1 ${{ matrix.version }}
   openai-test:
     name: Run openai test
     runs-on: ubuntu-latest
@@ -75,7 +100,7 @@ jobs:
       run:
         working-directory: dotnet
     if: success() && (github.ref == 'refs/heads/main')
-    needs: build
+    needs: aot-test
     steps:
     - uses: actions/checkout@v4
       with:

autogen/agentchat/contrib/vectordb/chromadb.py

@@ -83,7 +83,7 @@ def create_collection(
             if self.active_collection and self.active_collection.name == collection_name:
                 collection = self.active_collection
             else:
-                collection = self.client.get_collection(collection_name)
+                collection = self.client.get_collection(collection_name, embedding_function=self.embedding_function)
         except ValueError:
             collection = None
         if collection is None:
@@ -126,7 +126,9 @@ def get_collection(self, collection_name: str = None) -> Collection:
                 )
         else:
             if not (self.active_collection and self.active_collection.name == collection_name):
-                self.active_collection = self.client.get_collection(collection_name)
+                self.active_collection = self.client.get_collection(
+                    collection_name, embedding_function=self.embedding_function
+                )
         return self.active_collection
 
     def delete_collection(self, collection_name: str) -> None:

autogen/agentchat/conversable_agent.py

@@ -242,7 +242,7 @@ def __init__(
 
         # Registered hooks are kept in lists, indexed by hookable method, to be called in their order of registration.
         # New hookable methods should be added to this list as required to support new agent capabilities.
-        self.hook_lists = {
+        self.hook_lists: Dict[str, List[Callable]] = {
             "process_last_received_message": [],
             "process_all_messages_before_reply": [],
             "process_message_before_send": [],
@@ -2724,7 +2724,7 @@ def process_all_messages_before_reply(self, messages: List[Dict]) -> List[Dict]:
             processed_messages = hook(processed_messages)
         return processed_messages
 
-    def process_last_received_message(self, messages):
+    def process_last_received_message(self, messages: List[Dict]) -> List[Dict]:
         """
         Calls any registered capability hooks to use and potentially modify the text of the last message,
         as long as the last message is not a function call or exit command.
@@ -2758,6 +2758,7 @@ def process_last_received_message(self, messages):
         processed_user_content = user_content
         for hook in hook_list:
             processed_user_content = hook(processed_user_content)
+
         if processed_user_content == user_content:
             return messages  # No hooks actually modified the user's message.