Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make fastText an optional dependency #229

Closed
osma opened this issue Jan 15, 2019 · 0 comments
Closed

Make fastText an optional dependency #229

osma opened this issue Jan 15, 2019 · 0 comments
Milestone

Comments

@osma
Copy link
Member

osma commented Jan 15, 2019

The fastText package needs the native library to be compiled during install. While it has worked reasonably well, I think it would make sense to make all non-pure-Python dependencies optional so that the core Annif can be installed without any compilation of native code.

So the fasttext (actually fasttextmirror) dependency should be moved from install_requires to extras_requires in setup.py and similar for the Pipfile. The backend code should check whether the fasttext module can be imported and fail gracefully if not. Unit tests should also notice if fastText is missing and skip the tests that require it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant