Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement access levels for projects #246

Merged
merged 3 commits into from
Jan 29, 2019
Merged

Implement access levels for projects #246

merged 3 commits into from
Jan 29, 2019

Conversation

osma
Copy link
Member

@osma osma commented Jan 29, 2019

Fixes #237

@osma osma added this to the v0.39 milestone Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #246 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
+ Coverage   99.21%   99.24%   +0.02%     
==========================================
  Files          48       48              
  Lines        2179     2249      +70     
==========================================
+ Hits         2162     2232      +70     
  Misses         17       17
Impacted Files Coverage Δ
tests/test_rest.py 100% <100%> (ø) ⬆️
annif/project.py 100% <100%> (ø) ⬆️
annif/cli.py 99.41% <100%> (ø) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
tests/test_project.py 100% <100%> (ø) ⬆️
annif/rest.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e1d6cf...c751725. Read the comment docs.

@osma osma merged commit 3804bf9 into master Jan 29, 2019
@osma osma deleted the issue237-access-levels branch January 29, 2019 11:07
@osma
Copy link
Member Author

osma commented Jan 29, 2019

This pull request introduces 2 alerts when merging c751725 into 4e1d6cf - view on LGTM.com

new alerts:

  • 2 for Module is imported with 'import' and 'import from'

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant