Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid returnin nan values for Precision@K #248

Merged
merged 1 commit into from
Jan 29, 2019
Merged

Conversation

osma
Copy link
Member

@osma osma commented Jan 29, 2019

Fixes #247

@osma osma added the bug label Jan 29, 2019
@osma osma added this to the v0.39 milestone Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #248 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   99.24%   99.24%   +<.01%     
==========================================
  Files          48       48              
  Lines        2249     2252       +3     
==========================================
+ Hits         2232     2235       +3     
  Misses         17       17
Impacted Files Coverage Δ
annif/eval.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3804bf9...03571b0. Read the comment docs.

@osma osma merged commit d8a4d26 into master Jan 29, 2019
@osma osma deleted the issue247-precision-nan branch January 29, 2019 13:36
@osma
Copy link
Member Author

osma commented Jan 29, 2019

This pull request introduces 1 alert when merging 03571b0 into 3804bf9 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant