Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First implementation of VW regular backend #249

Merged
merged 24 commits into from
Jan 29, 2019
Merged

First implementation of VW regular backend #249

merged 24 commits into from
Jan 29, 2019

Conversation

osma
Copy link
Member

@osma osma commented Jan 29, 2019

Part of #230

Implements a vw_multi backend that currently only supports a VW one-against-all (oaa) classifier with a limited set of parameters. No support for online learning yet.

@osma osma added this to the v0.39 milestone Jan 29, 2019
@codecov
Copy link

codecov bot commented Jan 29, 2019

Codecov Report

Merging #249 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #249      +/-   ##
==========================================
+ Coverage   99.24%   99.28%   +0.04%     
==========================================
  Files          48       51       +3     
  Lines        2252     2386     +134     
==========================================
+ Hits         2235     2369     +134     
  Misses         17       17
Impacted Files Coverage Δ
annif/backend/fasttext.py 98.59% <100%> (-0.22%) ⬇️
annif/backend/__init__.py 100% <100%> (ø) ⬆️
tests/test_backend_vw.py 100% <100%> (ø)
annif/backend/mixins.py 100% <100%> (ø)
annif/backend/vw_multi.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8a4d26...92e737e. Read the comment docs.

@osma osma merged commit b3163f8 into master Jan 29, 2019
@osma osma deleted the vw-backend branch January 29, 2019 14:21
@osma
Copy link
Member Author

osma commented Jan 29, 2019

This pull request introduces 1 alert when merging 92e737e into d8a4d26 - view on LGTM.com

new alerts:

  • 1 for Unused import

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant