Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Error Correcting Tournament in vw_multi backend #252

Merged
merged 7 commits into from
Jan 30, 2019

Conversation

osma
Copy link
Member

@osma osma commented Jan 30, 2019

Part of #230

@osma osma added this to the v0.39 milestone Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #252 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #252      +/-   ##
=========================================
+ Coverage   99.28%   99.3%   +0.01%     
=========================================
  Files          51      51              
  Lines        2386    2431      +45     
=========================================
+ Hits         2369    2414      +45     
  Misses         17      17
Impacted Files Coverage Δ
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️
tests/test_backend_vw.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3163f8...4877f30. Read the comment docs.

@osma osma merged commit 94b1ca3 into master Jan 30, 2019
@osma osma deleted the issue230-vw-multi-ect branch January 30, 2019 13:24
@osma
Copy link
Member Author

osma commented Jan 30, 2019

This pull request fixes 1 alert when merging 4877f30 into b3163f8 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

Comment posted by LGTM.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant