Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move passes-related settings outside _create_params #253

Merged
merged 2 commits into from
Jan 30, 2019

Conversation

osma
Copy link
Member

@osma osma commented Jan 30, 2019

So they don't confuse model loading. Without this fix, annif eval seems to hang.
#230

@osma osma added the bug label Jan 30, 2019
@osma osma added this to the v0.39 milestone Jan 30, 2019
@codecov
Copy link

codecov bot commented Jan 30, 2019

Codecov Report

Merging #253 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #253      +/-   ##
=========================================
+ Coverage    99.3%   99.3%   +<.01%     
=========================================
  Files          51      51              
  Lines        2431    2432       +1     
=========================================
+ Hits         2414    2415       +1     
  Misses         17      17
Impacted Files Coverage Δ
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️
tests/test_backend_vw.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94b1ca3...7038111. Read the comment docs.

@osma osma merged commit b7c532f into master Jan 30, 2019
@osma osma deleted the issue230-vw-multi-passes branch January 30, 2019 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant