-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vw-multi backend: use input from other projects #256
Conversation
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
==========================================
- Coverage 99.31% 99.28% -0.03%
==========================================
Files 51 51
Lines 2466 2503 +37
==========================================
+ Hits 2449 2485 +36
- Misses 17 18 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not with my IDE in this computer, so couldn't check the code suggestions 😢 feel free to ignore and just proceed with the merge 👍
Thanks for all the suggestions @kinow ! I think this is much better now, and good enough for merging. |
Agreed! And thank you for the interesting pull requests! As you are sending pull requests instead of commiting directly, that is giving me some time to review and familiarise with what's coming in the next release. Plus, easier to get.notifications and manage them ☺ |
I like doing PRs against my own project because this way I can trigger all the CI and static analysis tools and see their result in one place. It's almost like having another person review your code as you're writing it, although now you did that for real :) |
Makes it possible to specify what inputs are used to build the VW model. Thus it's possible to use e.g. a well trained subject indexing algorithm as input to the vw classifier. #230