Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vw-multi backend: use input from other projects #256

Merged
merged 9 commits into from
Feb 5, 2019

Conversation

osma
Copy link
Member

@osma osma commented Feb 4, 2019

Makes it possible to specify what inputs are used to build the VW model. Thus it's possible to use e.g. a well trained subject indexing algorithm as input to the vw classifier. #230

@osma osma added this to the v0.39 milestone Feb 4, 2019
@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #256 into master will decrease coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   99.31%   99.28%   -0.03%     
==========================================
  Files          51       51              
  Lines        2466     2503      +37     
==========================================
+ Hits         2449     2485      +36     
- Misses         17       18       +1
Impacted Files Coverage Δ
tests/test_backend_vw_multi.py 100% <100%> (ø) ⬆️
annif/backend/fasttext.py 98.63% <100%> (+0.03%) ⬆️
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️
annif/backend/mixins.py 94.11% <100%> (-5.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e46e99...11943c7. Read the comment docs.

Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not with my IDE in this computer, so couldn't check the code suggestions 😢 feel free to ignore and just proceed with the merge 👍

annif/backend/fasttext.py Outdated Show resolved Hide resolved
annif/backend/vw_multi.py Show resolved Hide resolved
annif/backend/vw_multi.py Outdated Show resolved Hide resolved
@osma
Copy link
Member Author

osma commented Feb 5, 2019

Thanks for all the suggestions @kinow ! I think this is much better now, and good enough for merging.

@osma osma merged commit 131b993 into master Feb 5, 2019
@kinow
Copy link
Collaborator

kinow commented Feb 5, 2019

Agreed! And thank you for the interesting pull requests!

As you are sending pull requests instead of commiting directly, that is giving me some time to review and familiarise with what's coming in the next release.

Plus, easier to get.notifications and manage them ☺

@osma
Copy link
Member Author

osma commented Feb 5, 2019

I like doing PRs against my own project because this way I can trigger all the CI and static analysis tools and see their result in one place. It's almost like having another person review your code as you're writing it, although now you did that for real :)

@osma osma deleted the issue230-vw-multi-input-from-projects branch February 27, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants