Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for online learning #257

Merged
merged 13 commits into from
Feb 27, 2019
Merged

Support for online learning #257

merged 13 commits into from
Feb 27, 2019

Conversation

osma
Copy link
Member

@osma osma commented Feb 6, 2019

Part of #225 and #230. WIP. Needs CLI and REST API functionality too.

@osma osma added this to the v0.39 milestone Feb 6, 2019
@codecov
Copy link

codecov bot commented Feb 6, 2019

Codecov Report

Merging #257 into master will decrease coverage by 0.03%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
- Coverage   99.28%   99.24%   -0.04%     
==========================================
  Files          51       51              
  Lines        2503     2518      +15     
==========================================
+ Hits         2485     2499      +14     
- Misses         18       19       +1
Impacted Files Coverage Δ
tests/test_backend_vw_multi.py 100% <100%> (ø) ⬆️
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️
annif/backend/backend.py 94.11% <50%> (-2.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 131b993...a60c62f. Read the comment docs.

@codecov-io
Copy link

codecov-io commented Feb 6, 2019

Codecov Report

Merging #257 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #257      +/-   ##
==========================================
+ Coverage   99.27%   99.31%   +0.03%     
==========================================
  Files          52       52              
  Lines        2499     2629     +130     
==========================================
+ Hits         2481     2611     +130     
  Misses         18       18
Impacted Files Coverage Δ
annif/project.py 100% <100%> (ø) ⬆️
annif/cli.py 99.43% <100%> (+0.02%) ⬆️
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️
annif/backend/dummy.py 100% <100%> (ø) ⬆️
tests/test_cli.py 100% <100%> (ø) ⬆️
annif/corpus/document.py 100% <100%> (ø) ⬆️
tests/test_backend_vw_multi.py 100% <100%> (ø) ⬆️
annif/exception.py 87.5% <100%> (+1.13%) ⬆️
tests/test_corpus.py 100% <100%> (ø) ⬆️
tests/test_rest.py 100% <100%> (ø) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68e0f43...7624d21. Read the comment docs.

@osma
Copy link
Member Author

osma commented Feb 8, 2019

Note to self: the CLI and REST tests now try to perform online learning with the tfidf backend, but it doesn't (yet - see #226) really support it. There should be a mechanism for a backend to state whether it supports online learning or not, and the CLI and REST operations should report whether the operation succeeded or not depending on what the backend supports.

@osma
Copy link
Member Author

osma commented Feb 8, 2019

This pull request introduces 1 alert when merging 5b9d7df into 131b993 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Comment posted by LGTM.com

@osma
Copy link
Member Author

osma commented Feb 14, 2019

This pull request introduces 1 alert when merging bdef18f into 68e0f43 - view on LGTM.com

new alerts:

  • 1 for Unused local variable

Comment posted by LGTM.com

@osma
Copy link
Member Author

osma commented Feb 27, 2019

REST side now done. CLI still needs to indicate whether learning succeeded or not.

@osma osma changed the title Initial support for online learning in vw_multi backend Support for online learning Feb 27, 2019
@osma osma merged commit a3641d5 into master Feb 27, 2019
@osma osma deleted the issue225-feedback-online-learning branch February 27, 2019 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants