Show detailed error messages from REST API in UI #258
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #258 +/- ##
=======================================
Coverage 99.28% 99.28%
=======================================
Files 51 51
Lines 2503 2503
=======================================
Hits 2485 2485
Misses 18 18Continue to review full report at Codecov.
|
|
I think we can add a bit more of Vue and replace more of jQuery. Let me give it a try. |
|
See #260 |
|
#260 implemented this much better, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds detailed error messages which are shown in the web UI in case the analyze request to the REST API fails.
@kinow what do you think, I did this using jQuery but should this be Vue-ized somehow?