Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit character encoding for all calls to open() #263

Merged
merged 4 commits into from
Mar 6, 2019

Conversation

Veldhoen
Copy link
Contributor

@Veldhoen Veldhoen commented Mar 6, 2019

Issue #262 - Character encoding (Windows)

@codecov
Copy link

codecov bot commented Mar 6, 2019

Codecov Report

Merging #263 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #263   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          52       52           
  Lines        2629     2629           
=======================================
  Hits         2611     2611           
  Misses         18       18
Impacted Files Coverage Δ
annif/project.py 100% <100%> (ø) ⬆️
annif/cli.py 99.43% <100%> (ø) ⬆️
annif/backend/fasttext.py 98.63% <100%> (ø) ⬆️
annif/corpus/subject.py 100% <100%> (ø) ⬆️
annif/corpus/document.py 100% <100%> (ø) ⬆️
annif/corpus/convert.py 100% <100%> (ø) ⬆️
annif/backend/vw_multi.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d832514...a0afde3. Read the comment docs.

@osma osma added the bug label Mar 6, 2019
@osma osma added this to the v0.40 milestone Mar 6, 2019
@osma osma merged commit 75c51d0 into NatLibFi:master Mar 6, 2019
@osma
Copy link
Member

osma commented Mar 6, 2019

Had to fix the indent to make the PEP8 check pass.
Merged, thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants