Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports and declare dependencies used #271

Merged
merged 2 commits into from
Apr 16, 2019

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented Apr 16, 2019

Today I worked on a different project and decided to use click for the first time from scratch. Knowing Annif used it, I came right here to look for the setup.py to see what was there.

Only found click-log (interesting!), but not click. Then decided to look what other transitive dependencies were being used in the project.

I think the second commit covers all the dependencies used in code and tests. Added them to the respective groups of dependencies.

Cheers
Bruno

@kinow
Copy link
Collaborator Author

kinow commented Apr 16, 2019

Oh, and to avoid the unused imports issue in the __init__.py, I exported the imported code via __all__.

@codecov
Copy link

codecov bot commented Apr 16, 2019

Codecov Report

Merging #271 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
- Coverage   99.31%   99.31%   -0.01%     
==========================================
  Files          52       52              
  Lines        2629     2623       -6     
==========================================
- Hits         2611     2605       -6     
  Misses         18       18
Impacted Files Coverage Δ
tests/test_rest.py 100% <ø> (ø) ⬆️
tests/test_cli.py 100% <ø> (ø) ⬆️
tests/test_backend.py 100% <ø> (ø) ⬆️
annif/backend/__init__.py 100% <ø> (ø) ⬆️
tests/test_project.py 100% <ø> (ø) ⬆️
annif/corpus/__init__.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c51d0...6cae72d. Read the comment docs.

@osma osma added this to the v0.40 milestone Apr 16, 2019
@osma
Copy link
Member

osma commented Apr 16, 2019

Thanks @kinow, looks good!

@osma osma merged commit c8c370a into NatLibFi:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants