Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid calling update with empty dicts #276

Merged
merged 1 commit into from
May 14, 2019
Merged

Conversation

kinow
Copy link
Collaborator

@kinow kinow commented May 12, 2019

Was passing some functions with a debugger reading the code and noticed that here when the dict was not None, it could still be empty. And the update method was being called unnecessarily.

Won't cause any speed up, but still worth changing it I think?

@codecov
Copy link

codecov bot commented May 12, 2019

Codecov Report

Merging #276 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #276   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          52       52           
  Lines        2624     2624           
=======================================
  Hits         2606     2606           
  Misses         18       18
Impacted Files Coverage Δ
annif/backend/backend.py 96.42% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1381806...43f2aab. Read the comment docs.

@osma
Copy link
Member

osma commented May 14, 2019

Okay, why not. Thanks!

@osma osma merged commit ffc947f into NatLibFi:master May 14, 2019
@osma osma added this to the v0.41 milestone Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants