-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add vw_ensemble backend #284
Conversation
…235-vw-ensemble-backend
Codecov Report
@@ Coverage Diff @@
## master #284 +/- ##
==========================================
+ Coverage 99.32% 99.36% +0.04%
==========================================
Files 52 55 +3
Lines 2651 2842 +191
==========================================
+ Hits 2633 2824 +191
Misses 18 18
Continue to review full report at Codecov.
|
The Travis build breaks on Python 3.5 (the only Python version where VW is available). Apparently there's a problem with the unit test expecting the |
…hen starting with a clean datadir)
Still TODO:
|
…or vw_ensemble (no improvement in results)
This pull request introduces 7 alerts when merging 9f25308 into f9b1294 - view on LGTM.com new alerts:
This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog. Comment posted by LGTM.com |
This pull request introduces 6 alerts when merging 34dc5a4 into f9b1294 - view on LGTM.com new alerts:
|
Feature-wise everything should be done now. Test coverage is 100%. API docs are updated. The remaining quality issues can be ignored (most are false positives). |
I've done some testing on real data sets and although the results are not quite as good as I hoped quality-wise, the backend seems to be working well now after the latest fixes. |
Fixes #235
This PR adds a new Vowpal Wabbit based learning ensemble backend. It is an alternative for PAV. The implementation is based on ideas from the Annif-fusion experiments.
This is a draft PR. Some TODOs: