Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop requirements files, attempt to run "setup.py install" in rtd #285

Merged
merged 3 commits into from
Jun 28, 2019

Conversation

juhoinkinen
Copy link
Member

Remove unnecessary ´requirements` files and a package for their creation.

@codecov
Copy link

codecov bot commented Jun 25, 2019

Codecov Report

Merging #285 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #285   +/-   ##
=======================================
  Coverage   99.31%   99.31%           
=======================================
  Files          52       52           
  Lines        2624     2624           
=======================================
  Hits         2606     2606           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e2331f...d0728df. Read the comment docs.

@osma
Copy link
Member

osma commented Jun 28, 2019

Is this working properly? Can it be merged now?

@juhoinkinen
Copy link
Member Author

Yes, now this is working and mergable. There were some randomish problems about builds failing, but adding the .readthedocs.yml seems to solve those (using the same settings via RTD webpage worked from time to time).

For future reference: Wiping build environment in RTD can help to solve some problems

(Also, the .rst files can be removed from version control as they can automatically generated: #287.)

@osma osma added this to the v0.41 milestone Jun 28, 2019
@osma osma merged commit cc47afa into master Jun 28, 2019
@osma osma deleted the auto-generate-documentation-without-requirements-file branch June 28, 2019 13:31
@juhoinkinen juhoinkinen mentioned this pull request Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants