Add more features to the model in vw_ensemble #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iant) and "zero features" (both descriptor-specific and descriptor-invariant)
Codecov Report
@@ Coverage Diff @@
## master #288 +/- ##
==========================================
+ Coverage 99.36% 99.36% +<.01%
==========================================
Files 55 55
Lines 2842 2845 +3
==========================================
+ Hits 2824 2827 +3
Misses 18 18
Continue to review full report at Codecov.
|
osma
added a commit
that referenced
this pull request
Jul 5, 2019
…they introduce extra complexity without significantly improving results. Reverting the merge for now. The vw_ensemble backend needs more work, but it's better to have a simple version in master and build upon that. Revert "Merge pull request #288 from NatLibFi/issue235-more-features" This reverts commit 2ea1130, reversing changes made to 8521652.
osma
added a commit
that referenced
this pull request
Jul 5, 2019
…eatures Revert PR #288 additional features for vw_ensemble
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #235
This PR adds more features to the ML models built in the vw_ensemble backend:
In my experiments, these additional features seem to give a small improvement in results.