Use vw version 8.7 #296
Merged
Use vw version 8.7 #296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #296 +/- ##
=======================================
Coverage 99.36% 99.36%
=======================================
Files 55 55
Lines 2842 2842
=======================================
Hits 2824 2824
Misses 18 18Continue to review full report at Codecov.
|
|
Looks good to me. I think the Travis Python 3.5 build for PR #300 is currently failing because of a VW version mismatch so it would be a good idea to merge this PR first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vowpalwabbit version
8.7.0.post1was released 12.7.2019 in Pypi. It requires a few new dependencies to be installed, and change on the linking fix of libboost. The VW wikipage has been updated according to these.However, issue #291 states VW should be pinned to 8.5. Is that still valid now when newer version is released (note that 8.6 is not in Pypi)?