Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build but do not publish on pushes and PRs to all branches #310

Merged
merged 1 commit into from
Aug 9, 2019

Conversation

juhoinkinen
Copy link
Member

Previously drone built and published docker image to quay.io when a push was made to master branch. Thus if there was error in build, it was detected only after PR merge to master.

This adds the build step to the drone pipeline, which is run when a push is made to any branch or PR, but does not publish the image to quay.io. Failed build should thus be detected before merging to master.

@juhoinkinen juhoinkinen merged commit 51267b3 into master Aug 9, 2019
@juhoinkinen juhoinkinen deleted the dry-run-of-drone-builds-for-PRs branch August 9, 2019 07:41
@juhoinkinen juhoinkinen restored the dry-run-of-drone-builds-for-PRs branch August 9, 2019 08:33
@osma osma added this to the 0.42 milestone Aug 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants