Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin VW, Gensim, and Scikit-learn versions #317

Merged
merged 8 commits into from
Aug 23, 2019

Conversation

juhoinkinen
Copy link
Member

Pin versions:

  • sklearn to 0.21.x
  • gensim to 3.8.x
  • vowpalwabbit probably to 8.7.x

At the moment fasttext(mirror) is not pinned, maybe wait for resolving #290 by merging PR #292?

Closes #291.

@osma
Copy link
Member

osma commented Aug 20, 2019

I think we should pin fastText too, to the current version (fasttextmirror version 0.8.22). This way we are at least safe against unintended upgrades if fasttextmirror happens to change.

Unfortunately #292 is stuck currently due to a bug in the new fastText Python bindings. When we get around to merging that we should then update the pin to the new version.

@osma osma added this to the 0.42 milestone Aug 20, 2019
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general.

The pinned versions should probably be specified in setup.py too. For example, pip install annif[vw] should install VW 8.7, not some other version.

Pipfile Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Aug 21, 2019

Codecov Report

Merging #317 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #317   +/-   ##
=======================================
  Coverage   99.37%   99.37%           
=======================================
  Files          55       55           
  Lines        2867     2867           
=======================================
  Hits         2849     2849           
  Misses         18       18

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d67c082...c6e89cd. Read the comment docs.

@juhoinkinen juhoinkinen marked this pull request as ready for review August 21, 2019 13:04
@juhoinkinen
Copy link
Member Author

Also pinned versions in Wiki page for fasttext and VW installation with pip.

@osma osma merged commit 93695bd into master Aug 23, 2019
@juhoinkinen juhoinkinen deleted the issue291-pin-down-more-specific-versions-of-dependencies branch September 25, 2019 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin down more specific versions of dependencies
2 participants