Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not push docker image with dev tag to quay.io #323

Merged

Conversation

juhoinkinen
Copy link
Member

The image intended for development (i.e. one including the installed dev packages of Pipfile and pytest) was automatically build by drone and pushed to quay.io with the dev tag. However, that tag name could cause confusion (especially when tags with release versions will come to use).

This PR removes the drone step for building and publishing dev image, and the instructions in Wiki for using docker for development is updated with instructions to manually build the image for development.

Also removes unnecessary full-access to everyone for source code in image.

@juhoinkinen juhoinkinen added this to the 0.42 milestone Aug 27, 2019
@codecov
Copy link

codecov bot commented Aug 27, 2019

Codecov Report

Merging #323 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #323      +/-   ##
==========================================
- Coverage   99.48%   99.45%   -0.04%     
==========================================
  Files          56       56              
  Lines        2929     2943      +14     
==========================================
+ Hits         2914     2927      +13     
- Misses         15       16       +1
Impacted Files Coverage Δ
annif/exception.py 97.14% <0%> (-2.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaf0467...4bf6b26. Read the comment docs.

@juhoinkinen juhoinkinen merged commit 2fb6108 into master Aug 27, 2019
@juhoinkinen juhoinkinen deleted the remove-pushing-docker-image-with-dev-tag-from-quay.io branch August 27, 2019 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant