-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nn_ensemble backend #331
Conversation
This pull request introduces 4 alerts when merging 0cf82c5 into 6ac8431 - view on LGTM.com new alerts:
|
Codecov Report
@@ Coverage Diff @@
## master #331 +/- ##
==========================================
+ Coverage 99.51% 99.53% +0.01%
==========================================
Files 55 57 +2
Lines 3080 3203 +123
==========================================
+ Hits 3065 3188 +123
Misses 15 15
Continue to review full report at Codecov.
|
TODO items:
|
…id deprecation warnings from numpy 1.17
…eds at least pip 19.x)
TensorFlow 2.0.0 is out, I think it would make sense to switch to that instead of relying on 1.15.0rc1 which will be the last 1.x release anyway. |
managing tensorflow dependencies using Pipenv, this sidesteps the issue. This reverts commit a789f46.
This pull request introduces 1 alert when merging f12929a into 8e90e24 - view on LGTM.com new alerts:
|
np.expand_dims(score_vector.transpose(), 0)) | ||
return VectorSuggestionResult(results[0], project.subjects) | ||
|
||
def _create_model(self, sources, project): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any comments @juhoinkinen or @mvsjober to the Keras model defined here? Would you do something differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
This pull request introduces 1 alert when merging b9093e7 into 8ca56f4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging f0014df into 8ca56f4 - view on LGTM.com new alerts:
|
This pull request introduces 1 alert when merging ce49174 into 8ca56f4 - view on LGTM.com new alerts:
|
Neural network ensemble backend based on Keras and TensorFlow. WIP.
Creating the (draft) PR early on so that I get feedback from the QA tools etc.
Fixes #330