Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nn_ensemble backend #331

Merged
merged 31 commits into from
Oct 28, 2019
Merged

Add nn_ensemble backend #331

merged 31 commits into from
Oct 28, 2019

Conversation

osma
Copy link
Member

@osma osma commented Sep 23, 2019

Neural network ensemble backend based on Keras and TensorFlow. WIP.

Creating the (draft) PR early on so that I get feedback from the QA tools etc.

Fixes #330

@lgtm-com
Copy link

lgtm-com bot commented Sep 23, 2019

This pull request introduces 4 alerts when merging 0cf82c5 into 6ac8431 - view on LGTM.com

new alerts:

  • 3 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@codecov
Copy link

codecov bot commented Sep 23, 2019

Codecov Report

Merging #331 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #331      +/-   ##
==========================================
+ Coverage   99.51%   99.53%   +0.01%     
==========================================
  Files          55       57       +2     
  Lines        3080     3203     +123     
==========================================
+ Hits         3065     3188     +123     
  Misses         15       15
Impacted Files Coverage Δ
tests/test_backend_nn_ensemble.py 100% <100%> (ø)
annif/util.py 97.36% <100%> (+0.14%) ⬆️
annif/backend/__init__.py 100% <100%> (ø) ⬆️
annif/backend/nn_ensemble.py 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ca56f4...ce49174. Read the comment docs.

@osma
Copy link
Member Author

osma commented Sep 24, 2019

TODO items:

@osma osma added this to the Short term milestone Sep 24, 2019
@osma osma modified the milestones: Short term, 0.43 Sep 30, 2019
@osma
Copy link
Member Author

osma commented Oct 1, 2019

TensorFlow 2.0.0 is out, I think it would make sense to switch to that instead of relying on 1.15.0rc1 which will be the last 1.x release anyway.

@lgtm-com
Copy link

lgtm-com bot commented Oct 4, 2019

This pull request introduces 1 alert when merging f12929a into 8e90e24 - view on LGTM.com

new alerts:

  • 1 for Syntax error

@osma osma marked this pull request as ready for review October 7, 2019 13:13
@osma osma requested a review from juhoinkinen October 7, 2019 13:15
np.expand_dims(score_vector.transpose(), 0))
return VectorSuggestionResult(results[0], project.subjects)

def _create_model(self, sources, project):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any comments @juhoinkinen or @mvsjober to the Keras model defined here? Would you do something differently?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request introduces 1 alert when merging b9093e7 into 8ca56f4 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request introduces 1 alert when merging f0014df into 8ca56f4 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

@juhoinkinen juhoinkinen merged commit 35725a8 into master Oct 28, 2019
@juhoinkinen juhoinkinen deleted the issue330-nn-ensemble-backend branch October 28, 2019 12:55
@lgtm-com
Copy link

lgtm-com bot commented Oct 28, 2019

This pull request introduces 1 alert when merging ce49174 into 8ca56f4 - view on LGTM.com

new alerts:

  • 1 for Module-level cyclic import

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Neural network ensemble backend
2 participants