Further optimizations to tfidf backend + rearchitecting #336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… only used by a unit test, not real code
…FIDFBackend since nothing else uses it
TfidfTransformer, to avoid tokenizing the same text many times if it has multiple subjects
Codecov Report
@@ Coverage Diff @@
## master #336 +/- ##
==========================================
- Coverage 99.52% 99.51% -0.02%
==========================================
Files 56 55 -1
Lines 3166 3080 -86
==========================================
- Hits 3151 3065 -86
Misses 15 15
Continue to review full report at Codecov.
|
|
This pull request introduces 3 alerts when merging 3cc830b into 8e90e24 - view on LGTM.com new alerts:
|
|
This pull request introduces 4 alerts when merging fe4bdc5 into 8e90e24 - view on LGTM.com new alerts:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes quite a few things related to corpus handling. The ultimate goal is to optimize the
tfidfbackend training process, but on the way lots of things got cleaned up and streamlined.The general functionality for converting between document-oriented and subject-oriented corpora has been removed, as only the
tfidfbackend really requires it. The code to do that conversion now belongs to thetfidfbackend only, and it has been rewritten to avoid tokenizing the same text multiple times.There should be a significant improvement in train time: the new code is about twice as fast as the old one, or 5x as fast as the previous release.