Further optimizations to tfidf backend + rearchitecting #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes quite a few things related to corpus handling. The ultimate goal is to optimize the
tfidf
backend training process, but on the way lots of things got cleaned up and streamlined.The general functionality for converting between document-oriented and subject-oriented corpora has been removed, as only the
tfidf
backend really requires it. The code to do that conversion now belongs to thetfidf
backend only, and it has been rewritten to avoid tokenizing the same text multiple times.There should be a significant improvement in train time: the new code is about twice as fast as the old one, or 5x as fast as the previous release.