Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Python docker image version to 3.7 to fix build error #341

Merged
merged 1 commit into from
Oct 25, 2019

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Oct 25, 2019

Drone builds were failing. This was due to that the docker base image was pinned to tag 3-slim-buster, whose Python version was updated from 3.7 to 3.8.

Fix by pinning the tag to 3.7-slim-buster.

@codecov
Copy link

codecov bot commented Oct 25, 2019

Codecov Report

Merging #341 into master will increase coverage by 20.25%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #341       +/-   ##
===========================================
+ Coverage   79.25%   99.51%   +20.25%     
===========================================
  Files          55       55               
  Lines        3080     3080               
===========================================
+ Hits         2441     3065      +624     
+ Misses        639       15      -624
Impacted Files Coverage Δ
annif/analyzer/__init__.py 92.59% <0%> (+3.7%) ⬆️
tests/test_project.py 100% <0%> (+9.35%) ⬆️
annif/backend/__init__.py 100% <0%> (+12.9%) ⬆️
tests/test_analyzer_voikko.py 100% <0%> (+75%) ⬆️
annif/analyzer/voikko.py 100% <0%> (+88.23%) ⬆️
tests/test_backend_fasttext.py 100% <0%> (+88.63%) ⬆️
annif/backend/mixins.py 89.47% <0%> (+89.47%) ⬆️
tests/test_backend_vw_ensemble.py 100% <0%> (+89.74%) ⬆️
annif/backend/vw_ensemble.py 100% <0%> (+89.9%) ⬆️
annif/backend/fasttext.py 98.76% <0%> (+91.35%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1b27ae...fc4a22c. Read the comment docs.

@juhoinkinen juhoinkinen merged commit 8ca56f4 into master Oct 25, 2019
@juhoinkinen juhoinkinen deleted the fix-docker-build-pin-python-3.7 branch October 25, 2019 13:00
@osma osma added this to the 0.43 milestone Oct 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants