Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use sparse vectors in PAV backend #379

Merged
merged 4 commits into from
Jan 28, 2020
Merged

Use sparse vectors in PAV backend #379

merged 4 commits into from
Jan 28, 2020

Conversation

osma
Copy link
Member

@osma osma commented Jan 28, 2020

This PR changes the way the PAV backend stores the true labels and scores returned by source projects during training. They are now kept as (SciPy) sparse vectors, which saves a significant amount of RAM. Training times and suggestion results are the same as before.

Part of #377

@osma osma added this to the 0.46 milestone Jan 28, 2020
@codecov
Copy link

codecov bot commented Jan 28, 2020

Codecov Report

Merging #379 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #379      +/-   ##
==========================================
+ Coverage   99.38%   99.38%   +<.01%     
==========================================
  Files          59       59              
  Lines        3727     3738      +11     
==========================================
+ Hits         3704     3715      +11     
  Misses         23       23
Impacted Files Coverage Δ
annif/backend/pav.py 98.82% <100%> (+0.17%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1a09a...62c273f. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Jan 28, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@osma osma marked this pull request as ready for review January 28, 2020 10:29
@osma osma merged commit 21d92bf into master Jan 28, 2020
@osma osma deleted the issue377-pav-sparse-vectors branch May 14, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant