Pin flake8 to version 4.x to avoid pytest-flake8 breakage #598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
=======================================
Coverage 99.48% 99.48%
=======================================
Files 86 86
Lines 5636 5636
=======================================
Hits 5607 5607
Misses 29 29 Continue to review full report at Codecov.
|
juhoinkinen
added a commit
that referenced
this pull request
Aug 3, 2022
Merge to include pytest-flake8 fix #598
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a recently surfaced incompatibility that causes CI tests to fail. pytest-flake8 (version 1.1.1) is not compatible with flake8 version 5, released a few days ago. The PR pins the version of flake8 to 4.x, which fixes the issue for now but is probably not a good long term solution.
I think we need to reconsider the use of pytest-flake8. Many folks seem to be abandoning this flaky (heh) integration and instead switching to a setup where flake8 is run outside pytest. I will open a separate issue about this.