Fix limit parameter not passed to requests by HTTP backend #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 91 91
Lines 6817 6831 +14
=======================================
+ Hits 6793 6807 +14
Misses 24 24 ☔ View full report in Codecov by Sentry. |
|
juhoinkinen
changed the title
|
@CodiumAI-Agent /review |
PR Reviewer Guide 🔍
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the limit parameter in the project configuration had no effect to the number of the suggestions in the case of the HTTP backend. This is fixed by adding that parameter to the POST request, if it is used.
Also adds a test to verify that the the POST request by the HTTP backend actually contains the intended arguments.