Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Hugging Face Hub token from preupload_lfs_files() parameters #808

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

juhoinkinen
Copy link
Member

@juhoinkinen juhoinkinen commented Oct 1, 2024

The token was not passed to the preupload_lfs_files() function like it is needed for uploads when a user is not logged in with huggingface-cli.

@juhoinkinen juhoinkinen added the bug label Oct 1, 2024
@juhoinkinen juhoinkinen added this to the 1.2 milestone Oct 1, 2024
Copy link

sonarcloud bot commented Oct 1, 2024

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.60%. Comparing base (4b01501) to head (aed1f5a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #808   +/-   ##
=======================================
  Coverage   99.60%   99.60%           
=======================================
  Files          93       93           
  Lines        7132     7132           
=======================================
  Hits         7104     7104           
  Misses         28       28           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juhoinkinen juhoinkinen marked this pull request as ready for review October 1, 2024 13:02
@juhoinkinen juhoinkinen changed the title Fix from preupload_lfs_files() missing Hugging Face Hub token Fix missing Hugging Face Hub token from preupload_lfs_files() parameters Oct 1, 2024
@juhoinkinen juhoinkinen merged commit 3a5c12e into main Oct 2, 2024
17 checks passed
@juhoinkinen juhoinkinen deleted the fix-missing-token-param-from-preuploadlfsfiles branch October 2, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant