-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify translation of terms #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks very good - we will get rid of a lot of code - and seems to work well.
I'm not sure what is the best merging strategy here (should we merge directly to main
or to some other branch? @juhoinkinen ?) but once we figure that out, this can go in.
Hmm, I think it's best to merge to |
I changed the base branch, but now we have many more commits in this PR. I think there should be a merge from |
Ok, I'll merge on my laptop and push. |
To make "the extra commits" disappear from thia PR, I also had to switch the base branch to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged now IMHO
🎉 |
This PR simplifies translation of suggested terms by using the
language
parameter of Annif API'ssuggest
method. Calls to Finto API are removed.Implements #10