-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FINNA-2838] Add Finna specific OAI metadata format #3097
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tässä voisi olla hyötyä siitä, että yläjuoksulla tuo ensimmäinen blokki attachNonDeleted:stä irrotettaisiin omaksi metodiksi, jota attachNonDeleted kutsuu, niin ei tarvitsisi koko metodia yliajaa.
@@ -618,6 +640,18 @@ urls: | |||
type: array | |||
items: | |||
$ref: '#/components/schemas/Url' | |||
usageRights: | |||
vufind.method: getUsageRights | |||
description: Usage rights |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usage rights (see [usage_rights_str_mv at https://www.kiwi.fi/display/Finna/Kenttien+mappaukset+eri+formaateista+Finnan+indeksiin](https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights.map.sample))
type: string | ||
usageRightsExtended: | ||
vufind.method: getUsageRightsExt | ||
description: Usage rights extended |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extended usage rights (see https://github.com/NatLibFi/RecordManager-Finna/blob/dev/mappings/usage_rights_ext.map.sample)
// the supplied metadataPrefix is available. | ||
// If RecordDriver returns nothing, skip this record. | ||
if (empty($xml)) { | ||
return true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tämän pitäisi olla return false;
@@ -130,6 +130,12 @@ corporateAuthors: | |||
type: array | |||
items: | |||
type: string | |||
ctrlnum: | |||
vufind.method: getCtrlNum | |||
description: Ctrl num |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Record control numbers
@@ -337,6 +343,12 @@ lccn: | |||
type: array | |||
items: | |||
type: string | |||
majorGenres: | |||
vufind.method: getMajorGenres | |||
description: Major genres as array |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pelkkä Major genres
(type: array
kertoo tyypin)
public function getMediaTypesAsStrings(): array | ||
{ | ||
return array_map( | ||
fn ($entry) => $entry instanceof \VuFind\I18n\TranslatableString ? $entry->__toString() : $entry, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tässä pitäisi riittää (string)$entry
kaikissa tapauksissa.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohops, totta tosiaan
Adds couple fields to be exposed in the OAI response.
Could also be possible to open this in upstream with options to allow additional prefixes, but think it could be maybe unnecessary?
Requires: