Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab 'New and Deprecated' lists of concepts #1513

Closed
jeanninebeeken opened this issue Sep 14, 2023 · 3 comments · Fixed by #1529
Closed

Tab 'New and Deprecated' lists of concepts #1513

jeanninebeeken opened this issue Sep 14, 2023 · 3 comments · Fixed by #1529
Assignees
Labels

Comments

@jeanninebeeken
Copy link

Hi,

It seems that there are two issues concerning
"Deprecated Concepts
Deprecated concepts are concepts that are no more valid but are kept in the vocabulary for backward compatibility. Skosmos can detect deprecated concepts with :

an owl:deprecated true metadata on the skos:Concept;
optionnally, the dcterms:replacedBy pointing to the (possibly multiple) concepts that replace this one;

Deprecated concepts will not be visible in the alphabetical listing, in the hierarchical view, and cannot be searched. They can still be accessed through their URI."

  1. when setting skosmos:showDeprecated to 'false' the deprecated concepts are not searchable or displayed in the alphabetical list, BUT there are still listed in the Hierarchy tree;
  2. concepts that have the owl:depracted true element/value only, BUT do not have the (optional) dct:replacedBy element seem to be missed completely/altogether and do not show up in the 'New and Deprecated' lists at all.

Could you please provide a solution for esp. issue 2. Thanks.

Best wishes,
Jeannine

@osma
Copy link
Member

osma commented Sep 27, 2023

Thank you for reporting the problems @jeanninebeeken !

I have prepared a fix for problem 2 in PR #1529. It should solve the issue of deprecated concepts without a replacement not being shown on the New and Deprecated tab.

For problem 1, I think we need more clarification. I tested this and to me it seems that deprecated concepts are not shown in the hierarchy. Could you please open a new issue if you still experience this problem, and provide some more details, for example a screenshot?

@jeanninebeeken
Copy link
Author

jeanninebeeken commented Sep 27, 2023

Hi @osma,

Thank you for fixing issue 2. May I ask whether the fix will be part of/visble in version 2.17 or only from version 3.0 onwards.
As requested, I have created a new issue for problem 1, see #1530

Best wishes,
Jeannine

@osma
Copy link
Member

osma commented Sep 28, 2023

Thank you for fixing issue 2. May I ask whether the fix will be part of/visble in version 2.17 or only from version 3.0 onwards.

Please see #1529 (comment) . The fix is now available on the v2.16-maintenance branch so you can upgrade immediately.

I also created PR #1534 which performs the same fixes for the skosmos-3 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging a pull request may close this issue.

2 participants